Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24761 )
Change subject: IMPALA-15316: Support huge pages with aggressive decommit off ...................................................................... Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/24761/4/be/src/runtime/bufferpool/system-allocator.cc File be/src/runtime/bufferpool/system-allocator.cc: http://gerrit.cloudera.org:8080/#/c/24761/4/be/src/runtime/bufferpool/system-allocator.cc@166 PS4, Line 166: malloc_huge_page_support_ != MallocUtil::HugePageSupport::MADVISE_UNNECESSARY) { The same comment about comparing to MADVISE_COMPATIBLE could apply here. -- To view, visit http://gerrit.cloudera.org:8080/24761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13ac5f065104d5cf35efb5029ba3c4d482904096 Gerrit-Change-Number: 24761 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 28 Aug 2026 22:44:15 +0000 Gerrit-HasComments: Yes
