Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24608 )
Change subject: IMPALA-15175: Support HBO for AnalyticEvalNode cardinality ...................................................................... Patch Set 4: (1 comment) Rebased the patch. Will address Aleksandr's comments in the next patch set. http://gerrit.cloudera.org:8080/#/c/24608/4/fe/src/main/java/org/apache/impala/planner/JoinNode.java File fe/src/main/java/org/apache/impala/planner/JoinNode.java: http://gerrit.cloudera.org:8080/#/c/24608/4/fe/src/main/java/org/apache/impala/planner/JoinNode.java@1165 PS4, Line 1165: if (node instanceof AnalyticEvalNode) { > I have a general comment here. I know this should be reviewed after several This is a good suggestion. Resolved this by adding the buildHboOperandQualifierMap method in PlanNode in a previous patch: https://gerrit.cloudera.org/c/24426/23/fe/src/main/java/org/apache/impala/planner/PlanNode.java -- To view, visit http://gerrit.cloudera.org:8080/24608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d87ab472db9273622f48fa62bb1d8c12e04e86b Gerrit-Change-Number: 24608 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 31 Aug 2026 15:15:21 +0000 Gerrit-HasComments: Yes
