Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24693 )
Change subject: IMPALA-15236: Expose HBO match provenance ...................................................................... Patch Set 11: PS11 rewords the caveat on the cardinality line: "(from HBO, partition constants ignored)" is now "(from HBO, key ignores partition constants)". The words moved because the caveat travels up the plan with the key - an aggregate over a scan on partition predicates carries it while having no partition predicates of its own, which the goldens here show. The enum returns the words now and PlanNode adds the punctuation around them. Nothing else moved: same gating, same details line, same ratio. PrintUtilsTest and HistoricalStatsTest pass, and TestHBO passes end to end. Putting the old wording back in the code and leaving the goldens alone fails three of its tests, so they do check this. -- To view, visit http://gerrit.cloudera.org:8080/24693 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d2deaaf78a2a41353454ba634a247d8c69825bf Gerrit-Change-Number: 24693 Gerrit-PatchSet: 11 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 31 Aug 2026 15:05:09 +0000 Gerrit-HasComments: No
