Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10908 )
Change subject: IMPALA-7209: Disallow self referencing in ALTER VIEW statements ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/10908/2/fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java: http://gerrit.cloudera.org:8080/#/c/10908/2/fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java@65 PS2, Line 65: TableRef tblRef = new TableRef(tableName_.toPath(), null); : tblRef = analyzer.resolveTableRef(tblRef); nit: can be simplified to TableRef tblRef = analyzer.resolveTableRef(new TableRef(tableName_.toPath(), null)); http://gerrit.cloudera.org:8080/#/c/10908/2/fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java@79 PS2, Line 79: Self reference nit: Self-reference http://gerrit.cloudera.org:8080/#/c/10908/2/fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java@91 PS2, Line 91: throw new AnalysisException("Subqueries not supported for " + : stmt.getClass().getSimpleName() + " statements"); I'm a bit torn whether we should throw an AnalysisException or have a Preconditions check since this condition should never happen given that the parser doesn't support this syntax. Let me know what you think? -- To view, visit http://gerrit.cloudera.org:8080/10908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17c231c9d74d9d411463a408b086eb874090b9b7 Gerrit-Change-Number: 10908 Gerrit-PatchSet: 2 Gerrit-Owner: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Comment-Date: Wed, 11 Jul 2018 18:36:05 +0000 Gerrit-HasComments: Yes
