Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24744 )

Change subject: IMPALA-15290: Retry for exists check in 
HadoopFsCommandLineClient
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24744/2/tests/util/hdfs_util.py
File tests/util/hdfs_util.py:

http://gerrit.cloudera.org:8080/#/c/24744/2/tests/util/hdfs_util.py@299
PS2, Line 299:         files += [fname]
             :     return files
             :
             :   def exists(self, path):
             :     """Checks if a particular path exists.
             :
             :     'hdfs dfs -test -e' exits 0 if the path exists. A missing 
path exits non-zero
             :     with empty stderr, while a transient failure (e.g. S3 503 
Slow Down) exits non-zero
             :     WITH a message on stderr. Only the latter is retried, with 
exponential backoff.
             :     Genuine absence returns False immediately."""
> Should we make this a loop and retry more than once?
Added retry with exponential backoff. Also fixed a mistake here that "not 
stderr.strip()" should remove "not".



--
To view, visit http://gerrit.cloudera.org:8080/24744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I071472529ec1b923e74e960a24e19b9e70c80011
Gerrit-Change-Number: 24744
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Xuebin Su <[email protected]>
Gerrit-Comment-Date: Tue, 01 Sep 2026 02:52:42 +0000
Gerrit-HasComments: Yes

Reply via email to