Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24592 )
Change subject: IMPALA-15189: Support HBO for SortNode cardinality ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/24592/6/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java File fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java: http://gerrit.cloudera.org:8080/#/c/24592/6/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java@1352 PS6, Line 1352: analyticFragment.addPlanRoot(upperTopN); > Yes - the local Top-N in the new hbo-analytic-topn.test. It runs below the This is harmless since the local sort node's per-instance cardinality matches the final sort node's. Unlike createOrderByFragment() where we add its OFFSET to its LIMIT so we need to invoke computeStats() for childSortNode again. Added the comment in SortNode.computeStats() since this comment is now removed. http://gerrit.cloudera.org:8080/#/c/24592/7/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java File fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java: http://gerrit.cloudera.org:8080/#/c/24592/7/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java@1381 PS7, Line 1381: if (node.isPartitionedTopN()) { > parentSortNode is assigned in both branches and never read now - the setTop Oops, fixed this bug and added testDistributedTopNWithTiesStorePath to cover this. -- To view, visit http://gerrit.cloudera.org:8080/24592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib829887a91593bee124d56e661e714575fe3be97 Gerrit-Change-Number: 24592 Gerrit-PatchSet: 8 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 03 Sep 2026 15:33:05 +0000 Gerrit-HasComments: Yes
