David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/10922 )
Change subject: IMPALA-7279: Fix flakiness in test_rows_availability ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10922/1/tests/util/parse_util.py File tests/util/parse_util.py: http://gerrit.cloudera.org:8080/#/c/10922/1/tests/util/parse_util.py@83 PS1, Line 83: if (match[2] == 'h'): Also, rather than the if/elif construction, you could maybe do this: pattern = r'(?P<value>[0-9]+\.?[0-9]*?)(?P<units>\D+)' matches = list(re.finditer(pattern, duration)) # You need list() here if you plan to assert assert matches, 'Failed to parse duration string %s' % duration times = {'h': 0, 'm': 0, 's': 0, 'ms': 0} for match in matches: parsed = match.groupdict() times[parsed['units']] = float(parsed['value']) return times['h'] * 60 * 60 * 1000 + times['m'] * 60 * 1000 + times['s'] * 1000 + times['ms'] -- To view, visit http://gerrit.cloudera.org:8080/10922 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7634869823d8cc4059048dd5d3c3a984744f3be Gerrit-Change-Number: 10922 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Comment-Date: Wed, 11 Jul 2018 19:40:14 +0000 Gerrit-HasComments: Yes
