Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24608 )
Change subject: IMPALA-15175: Support HBO for AnalyticEvalNode cardinality ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/24608/6/fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java File fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java: http://gerrit.cloudera.org:8080/#/c/24608/6/fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java@1343 PS6, Line 1343: + "op.rank() OVER (PARTITION BY a.int_col ORDER BY b.id ASC)," > These `a.` and `b.` are the query's aliases, and they land inside the HBO k The expected keys in PS8 now use canonical qualifiers and the standardized window. This addresses my concern. -- To view, visit http://gerrit.cloudera.org:8080/24608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d87ab472db9273622f48fa62bb1d8c12e04e86b Gerrit-Change-Number: 24608 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Sun, 06 Sep 2026 07:26:43 +0000 Gerrit-HasComments: Yes
