Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10895 )
Change subject: IMPALA-7129: Fixing path to UBSAN suppressions. ...................................................................... Patch Set 6: The typo broke my testing. This time I tested it by removing the suppressions file and getting the expected file not found error. If it's in the right place, no error. Turns out you need to do an extra layering of quoting. This makes sense since CMake is generating makefiles which are doing shell-style evaluation. -- To view, visit http://gerrit.cloudera.org:8080/10895 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5295c2d1bddbea585a761b85a51eadecf10d191d Gerrit-Change-Number: 10895 Gerrit-PatchSet: 6 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Wed, 11 Jul 2018 21:42:44 +0000 Gerrit-HasComments: No
