Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24798 )
Change subject: IMPALA-15219: (Addendum) Harden AI endpoint URL validation with libcurl ...................................................................... IMPALA-15219: (Addendum) Harden AI endpoint URL validation with libcurl This patch replaces the old, customized substring-based URL parser with the standard libcurl API for ExtractHost(). Using a standard library for ExtractHost() is better to prevent most edge-case bypasses and safety concerns. Tests: Added more edge cases in AiFunctionsTest and AiFunctionsTestAdditionalSites. Passed core tests. Change-Id: Id787af79c78ac91099b03cdf587db5d1504e5eb5 Reviewed-on: http://gerrit.cloudera.org:8080/24798 Reviewed-by: Michael Smith <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exprs/ai-functions-ir.cc M be/src/exprs/expr-test.cc 2 files changed, 118 insertions(+), 16 deletions(-) Approvals: Michael Smith: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/24798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id787af79c78ac91099b03cdf587db5d1504e5eb5 Gerrit-Change-Number: 24798 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
