Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24811 )
Change subject: IMPALA-15282: Export Substrait plan from Calcite planner (prototype) ...................................................................... Patch Set 1: (7 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24811/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/SubstraitPlanExporter.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/SubstraitPlanExporter.java: http://gerrit.cloudera.org:8080/#/c/24811/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/SubstraitPlanExporter.java@35 PS1, Line 35: import org.apache.calcite.plan.RelOptTable; unused import: org.apache.calcite.plan.RelOptTable http://gerrit.cloudera.org:8080/#/c/24811/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/SubstraitPlanExporter.java@40 PS1, Line 40: import org.apache.calcite.rel.core.TableScan; unused import: org.apache.calcite.rel.core.TableScan http://gerrit.cloudera.org:8080/#/c/24811/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/SubstraitPlanExporter.java@48 PS1, Line 48: import org.apache.impala.analysis.TimeTravelSpec; unused import: org.apache.impala.analysis.TimeTravelSpec http://gerrit.cloudera.org:8080/#/c/24811/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/SubstraitPlanExporter.java@154 PS1, Line 154: return new Exported((io.substrait.proto.Plan) clampSubsecondPrecision(proto).build()); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/24811/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/SubstraitPlanExporter.java@178 PS1, Line 178: private static final ImmutableSet<String> SUBSECOND_PRECISION_MESSAGES = ImmutableSet.of( line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24811/1/tests/custom_cluster/test_substrait_export.py File tests/custom_cluster/test_substrait_export.py: http://gerrit.cloudera.org:8080/#/c/24811/1/tests/custom_cluster/test_substrait_export.py@112 PS1, Line 112: v flake8: U100 Unused argument 'vector' http://gerrit.cloudera.org:8080/#/c/24811/1/tests/custom_cluster/test_substrait_export.py@192 PS1, Line 192: v flake8: U100 Unused argument 'vector' -- To view, visit http://gerrit.cloudera.org:8080/24811 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90a55a55e8416389847841a8495379759acd4ed7 Gerrit-Change-Number: 24811 Gerrit-PatchSet: 1 Gerrit-Owner: Jiyoung Yoo <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 10 Sep 2026 16:51:05 +0000 Gerrit-HasComments: Yes
