Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24848 )
Change subject: IMPALA-15181: Smallify strings in GroupingAggregator's DeepCopy ...................................................................... Patch Set 1: (2 comments) Thanks for working on this! http://gerrit.cloudera.org:8080/#/c/24848/1/be/src/exec/grouping-aggregator-ir.cc File be/src/exec/grouping-aggregator-ir.cc: http://gerrit.cloudera.org:8080/#/c/24848/1/be/src/exec/grouping-aggregator-ir.cc@331 PS1, Line 331: sv->Smallify(); : if (sv->IsSmall()) return 0; nit: could be: if (sv->Smallify()) return 0; http://gerrit.cloudera.org:8080/#/c/24848/1/be/src/exec/grouping-aggregator.cc File be/src/exec/grouping-aggregator.cc: http://gerrit.cloudera.org:8080/#/c/24848/1/be/src/exec/grouping-aggregator.cc@538 PS1, Line 538: Avoid branching CanBeSmallified adds a branch. We could write this instead: varlen_size += sv->ExternalLen(true /*assume_smallify*/) * !ht_ctx_->ExprValueNull(expr_idx); -- To view, visit http://gerrit.cloudera.org:8080/24848 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22311d9cb678874d5c53f19811fa335b646c8d6f Gerrit-Change-Number: 24848 Gerrit-PatchSet: 1 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 15 Sep 2026 14:19:17 +0000 Gerrit-HasComments: Yes
