Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24858 )

Change subject: PEND: Add support for lld
......................................................................


Patch Set 1:

(4 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24858/1/bin/run-backend-tests.sh
File bin/run-backend-tests.sh:

http://gerrit.cloudera.org:8080/#/c/24858/1/bin/run-backend-tests.sh@41
PS1, Line 41: export 
PATH="${IMPALA_TOOLCHAIN_PACKAGES_HOME}/llvm-${IMPALA_LLVM_TOOLS_VERSION}/bin:${PATH}"
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/24858/1/bin/run-binary.sh
File bin/run-binary.sh:

http://gerrit.cloudera.org:8080/#/c/24858/1/bin/run-binary.sh@35
PS1, Line 35: export 
PATH="${IMPALA_TOOLCHAIN_PACKAGES_HOME}/llvm-${IMPALA_LLVM_TOOLS_VERSION}/bin:${PATH}"
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/24858/1/bin/run-jvm-binary.sh
File bin/run-jvm-binary.sh:

http://gerrit.cloudera.org:8080/#/c/24858/1/bin/run-jvm-binary.sh@39
PS1, Line 39: export 
PATH="${IMPALA_TOOLCHAIN_PACKAGES_HOME}/llvm-${IMPALA_LLVM_TOOLS_VERSION}/bin:${PATH}"
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/24858/1/bin/run_clang_tidy.sh
File bin/run_clang_tidy.sh:

http://gerrit.cloudera.org:8080/#/c/24858/1/bin/run_clang_tidy.sh@61
PS1, Line 61: export 
PATH="${IMPALA_TOOLCHAIN_PACKAGES_HOME}/llvm-${IMPALA_LLVM_TOOLS_VERSION}/bin/:$PATH"
line too long (92 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/24858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09913c2551f17497546f91d506bf5bef4f47e292
Gerrit-Change-Number: 24858
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Tue, 15 Sep 2026 21:16:42 +0000
Gerrit-HasComments: Yes

Reply via email to