Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24426 )

Change subject: IMPALA-14601: Support HBO for JoinNode cardinality
......................................................................


Patch Set 35:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24426/35/fe/src/main/java/org/apache/impala/planner/AggregationNode.java
File fe/src/main/java/org/apache/impala/planner/AggregationNode.java:

http://gerrit.cloudera.org:8080/#/c/24426/35/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@839
PS35, Line 839:     sb.append("|Preagg:").append(isPreagg_)
It's already mentioned in the commit message: 
https://gerrit.cloudera.org/c/24426/35//COMMIT_MSG#43

> This patch also renames the HBO key string fields to use Camel names,...

Is that OK or do you want more info? Note that we provide backward 
compatibility across released minor versions but not commits. The HBO feature 
is not released in any version yet. So I think it's a chance to tidy up the 
field names.



--
To view, visit http://gerrit.cloudera.org:8080/24426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70b655ae7027d0d9eb8e9fae9ba2e1b7ad9876b4
Gerrit-Change-Number: 24426
Gerrit-PatchSet: 35
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Comment-Date: Thu, 17 Sep 2026 01:22:17 +0000
Gerrit-HasComments: Yes

Reply via email to