Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24814 )
Change subject: IMPALA-15354: bump Thrift to 0.24.0 - C++ parts ...................................................................... IMPALA-15354: bump Thrift to 0.24.0 - C++ parts Switching from 0.16.0-p7 to 0.24.0-p3 needed a few changes: - Thrift changed the way it prints global output, needing GlobalOutput() replaced with TOutput::instance() - some struct sizes shrinked due to not generating virtual destructors and thus omitting vtable pointers - patches in TSslSocket were removed in native-toolchain, moving the logic to Impala by passing SslContext to Thrift Removed TSslSocket patches: https://github.com/cloudera/native-toolchain/blob/master/source/thrift/thrift-0.16.0-patches/0001-TLS-forward-compatibility.patch https://github.com/cloudera/native-toolchain/blob/master/source/thrift/thrift-0.16.0-patches/0002-IMPALA-11195-Disable-SSL-renegotiations.patch That area was changed in Thrift, so I decided to move the logic to Impala instead of rebasing the patches. With the change I saw common OOM kills during build - my guess is that somehow the order changed, causing more overlap between ld.gold and maven. Left 6 GB for maven, which leads to 11 instead of 12 parallel linkers on a 64 GB machine. Testing: - the risky parts are the SSL changes, these are fairly covered in BE and custom cluster tests Change-Id: Ieea10df03996fef64ea25f51c9e5e4e47c8cefa1 Reviewed-on: http://gerrit.cloudera.org:8080/24814 Reviewed-by: Peter Rozsa <[email protected]> Tested-by: Csaba Ringhofer <[email protected]> --- M be/src/rpc/TAcceptQueueServer.cpp M be/src/rpc/thrift-util.cc M be/src/rpc/thrift-util.h M be/src/transport/TSaslTransport.h M be/src/util/container-util.h M be/src/util/gflag-validator-util-test.cc M bin/impala-config.sh 7 files changed, 83 insertions(+), 32 deletions(-) Approvals: Peter Rozsa: Looks good to me, approved Csaba Ringhofer: Verified -- To view, visit http://gerrit.cloudera.org:8080/24814 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ieea10df03996fef64ea25f51c9e5e4e47c8cefa1 Gerrit-Change-Number: 24814 Gerrit-PatchSet: 11 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
