Stamatis Zampetakis has posted comments on this change. ( http://gerrit.cloudera.org:8080/24870 )
Change subject: IMPALA-15334: Decompose unrewritable CTE suggestions to explore more rewrites ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/24870/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24870/1//COMMIT_MSG@18 PS1, Line 18: To prevent potentially high planning times due to the bigger search > Have you quantified this at all? The new decomposition logic has worst case time & space complexity linear to the size of the query. It's O(n) where n the number of operators/RelNodes. Planning complexity should not be affected much but the extra traversals will incur some overhead. http://gerrit.cloudera.org:8080/#/c/24870/1/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/24870/1/common/thrift/Query.thrift@837 PS1, Line 837: 207: optional bool cte_rewritable_decomposition = false > CTEs are already disabled by default, not sure I'd add another query option Indeed at this point the additional option does not bring much value I will remove it. http://gerrit.cloudera.org:8080/#/c/24870/1/tests/query_test/test_calcite_planner.py File tests/query_test/test_calcite_planner.py: http://gerrit.cloudera.org:8080/#/c/24870/1/tests/query_test/test_calcite_planner.py@60 PS1, Line 60: u > flake8: U100 Unused argument 'unique_database' Ack. Will address in the next push. http://gerrit.cloudera.org:8080/#/c/24870/1/tests/query_test/test_calcite_planner.py@67 PS1, Line 67: u > flake8: U100 Unused argument 'unique_database' Ack. Will address in the next push. -- To view, visit http://gerrit.cloudera.org:8080/24870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5aa335a0d61ea4b4a85a22f57e13e1e2083d0736 Gerrit-Change-Number: 24870 Gerrit-PatchSet: 1 Gerrit-Owner: Stamatis Zampetakis <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Stamatis Zampetakis <[email protected]> Gerrit-Comment-Date: Fri, 18 Sep 2026 14:10:27 +0000 Gerrit-HasComments: Yes
