Csaba Ringhofer has uploaded this change for review. (
http://gerrit.cloudera.org:8080/24900
Change subject: Move HttpClient-5 shared-cookie test out of LdapHS2Test for
Apache Hive builds
......................................................................
Move HttpClient-5 shared-cookie test out of LdapHS2Test for Apache Hive builds
testHiveserver2SharedCookie installs an HttpClient response interceptor to
capture
the returned cookie, which requires the Apache HttpClient 5 API and thus the
Thrift
0.24 THttpClient(String, CloseableHttpClient) constructor. Apache Hive 2/3
builds pin
Thrift to 0.11 (IMPALA-11801), whose THttpClient takes an HttpClient 4 client,
so the
test cannot compile there:
incompatible types:
org.apache.hc.client5.http.impl.classic.CloseableHttpClient
cannot be converted to org.apache.http.client.HttpClient
Move the test into its own LdapHS2SharedCookieTest so the rest of LdapHS2Test
keeps
compiling and running on both Thrift versions, and exclude the new file from
test
compilation in the apache-hive-3 profile (apache-hive-2 already skips test
compile).
The default (Thrift 0.24) build compiles and runs it unchanged. The second and
third
transports in the test, which do not need the interceptor, now use
THttpClient(url).
Change-Id: Ic9b616b1cdcf8184607dda60c87341d46d64caaa
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
---
M fe/pom.xml
A fe/src/test/java/org/apache/impala/customcluster/LdapHS2SharedCookieTest.java
M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java
3 files changed, 212 insertions(+), 105 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/24900/1
--
To view, visit http://gerrit.cloudera.org:8080/24900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9b616b1cdcf8184607dda60c87341d46d64caaa
Gerrit-Change-Number: 24900
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <[email protected]>
