Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23709 )
Change subject: IMPALA-13552: Add support for size()/length() for array/map types ...................................................................... Patch Set 8: (1 comment) Thanks for pointing it out again. http://gerrit.cloudera.org:8080/#/c/23709/4/be/src/exprs/anyval-util.h File be/src/exprs/anyval-util.h: http://gerrit.cloudera.org:8080/#/c/23709/4/be/src/exprs/anyval-util.h@210 PS4, Line 210: case TYPE_VARIANT: return sizeof(VariantVal); > Why do we need to add the mapping for TYPE_STRUCT? Its been a while since Ive worked on this and didnt realise this earlier. We don’t need TYPE_STRUCT for IMPALA-13552 itself. The feature only adds size()/length() for ARRAY and MAP. Removed the mapping for TYPE_STRUCT. Also fixed a small bug in AnyValUtil::SetAnyVal(). There was a layout mismatch affecting disable_codegen=true path as we were passing CollectionValue to SetAnyVal() on the interpreted path, while Size() needs CollectionVal. -- To view, visit http://gerrit.cloudera.org:8080/23709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85b50386790657ea035addb35eed959d71810ab2 Gerrit-Change-Number: 23709 Gerrit-PatchSet: 8 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Tue, 22 Sep 2026 11:22:58 +0000 Gerrit-HasComments: Yes
