Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24835 )
Change subject: IMPALA-15346: Fix IllegalStateException in createInsertEvents ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/24835/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24835/1//COMMIT_MSG@9 PS1, Line 9: when inserting : empty results into an unpartitioned table > If the partition was already empty and 0 rows are added by overwrite, then > similarly to adding 0 rows, IMO the best would be to treat it as NOOP. Agree that this is something we can optimize, maybe in a separate ticket. The bug also exists when the unpartitioned table is non-empty so we do need a fix. Added a test case for this. UPDATE: I just realized the empty map is created by catalogd itself in getFileMetadata(), not passed from the coordinator. The bug is due to this change: https://gerrit.cloudera.org/c/22872/18/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java#7924 Updated the solution to fix getFileMetadata() instead. -- To view, visit http://gerrit.cloudera.org:8080/24835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0eb366f55f4e95b229a57297e42d14760b31be21 Gerrit-Change-Number: 24835 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 22 Sep 2026 14:41:29 +0000 Gerrit-HasComments: Yes
