Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24896 )
Change subject: IMPALA-15381: Reduce reservoir RNG state ...................................................................... Patch Set 3: > Patch Set 3: > > > Patch Set 3: Code-Review+1 > > > > I tried > > query_test/test_aggregation.py::TestTPCHAggregationQueries::test_tpch_stress > > with this change, and it makes the overall test slightly faster (~1.41s to > > ~1.35s). > > Hmm, that's probably noise, since the test doesn't use any of the sampling > methods. Maybe HistogramTest.* works as a quick perf check: that goes from 992ms to 962ms. -- To view, visit http://gerrit.cloudera.org:8080/24896 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e046e3f0c1b91f1761ce578601a330bd864eb84 Gerrit-Change-Number: 24896 Gerrit-PatchSet: 3 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 22 Sep 2026 15:46:50 +0000 Gerrit-HasComments: No
