Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24888 )

Change subject: IMPALA-15369: Check for the CRC32 extension at startup on ARM64
......................................................................


Patch Set 2:

(1 comment)

Thanks for the comments!

http://gerrit.cloudera.org:8080/#/c/24888/1/be/src/util/cpu-info.cc
File be/src/util/cpu-info.cc:

http://gerrit.cloudera.org:8080/#/c/24888/1/be/src/util/cpu-info.cc@275
PS1, Line 275: #elif defined(__aarch64__)
> Is it possible to include CRC32 into the CpuInfo class, that way it would b
Added it to CpuInfo, turns out we can still use /proc/cpuinfo as well.



--
To view, visit http://gerrit.cloudera.org:8080/24888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01f8f8009e6e2d8dbfd324d83353b0d4dbf1d4c
Gerrit-Change-Number: 24888
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Tue, 22 Sep 2026 17:24:30 +0000
Gerrit-HasComments: Yes

Reply via email to