Xuebin Su has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24886 )

Change subject: IMPALA-15374: Roll back current_row_ when undoing a level read 
ahead
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

> Uploaded patch set 1.

Thanks!

http://gerrit.cloudera.org:8080/#/c/24886/1/be/src/exec/parquet/parquet-column-readers.h
File be/src/exec/parquet/parquet-column-readers.h:

http://gerrit.cloudera.org:8080/#/c/24886/1/be/src/exec/parquet/parquet-column-readers.h@449
PS1, Line 449:   /// with the rep/def levels.
nit: How about adding some comments to elaborate?



-- 
To view, visit http://gerrit.cloudera.org:8080/24886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icaf0aab770d87505513b0168f52f96480eda3202
Gerrit-Change-Number: 24886
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Xuebin Su <[email protected]>
Gerrit-Comment-Date: Wed, 23 Sep 2026 02:50:48 +0000
Gerrit-HasComments: Yes

Reply via email to