Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24894 )
Change subject: IMPALA-15361: Read Hive 4 timestamp stats ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/24894/4/fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java File fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java: http://gerrit.cloudera.org:8080/#/c/24894/4/fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java@114 PS4, Line 114: * Returns TIMESTAMP statistics in the representation used by Impala. Hive 4 has a > This is a Thrift generated class, not some Hive internal calls right? It co Done. A shared hive_metastore.thrift would also remove the reflection here. http://gerrit.cloudera.org:8080/#/c/24894/4/fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java@136 PS4, Line 136: throw new IllegalStateException("Unable to read Hive 4 TIMESTAMP statistics", e); > Can you add to the class comments that this is also used with Hive 4, as th Done, with IMPALA-13647. -- To view, visit http://gerrit.cloudera.org:8080/24894 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b99acbe65665226938b2e4ac5191063d3925426 Gerrit-Change-Number: 24894 Gerrit-PatchSet: 4 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 23 Sep 2026 10:20:22 +0000 Gerrit-HasComments: Yes
