Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24837 )
Change subject: IMPALA-15347: Move static S3 credential handling into S3ConnCredentials ...................................................................... Patch Set 2: Code-Review+2 (2 comments) LGTM! http://gerrit.cloudera.org:8080/#/c/24837/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24837/2//COMMIT_MSG@26 PS2, Line 26: Co-Authored-By nit: Should be 'Assisted-by' http://gerrit.cloudera.org:8080/#/c/24837/2/be/src/runtime/CMakeLists.txt File be/src/runtime/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/24837/2/be/src/runtime/CMakeLists.txt@69 PS2, Line 69: s3-conn-credentials.cc nit: Other entries are in alphabetic order -- To view, visit http://gerrit.cloudera.org:8080/24837 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie48cbb0c313f32242c4fce6603eab3e54d08cabd Gerrit-Change-Number: 24837 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 24 Sep 2026 15:06:54 +0000 Gerrit-HasComments: Yes
