Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24934 )
Change subject: IMPALA-15416: Fix compound predicate push-down test for Calcite ...................................................................... IMPALA-15416: Fix compound predicate push-down test for Calcite TestIcebergTable.test_compound_predicate_push_down failed in the Calcite planner build with an unexpected NumRowGroups value (10 instead of 12) for the query with the following predicate: not (col_bi + 1 != 123 or col_db = 2.71822 or col_i = -1) The legacy planner cannot push this predicate down to Iceberg, as 'col_bi + 1 != 123' cannot be converted to an Iceberg expression. Calcite pushes the NOT into the OR, so the predicates become separate conjuncts, and 'NOT col_db = 2.71822' is pushed down to Iceberg. Since the Iceberg 1.11 upgrade (IMPALA-15330) Iceberg skips data files for NOT_EQ predicates when the lower and upper bounds are equal to the literal, which is true for two data files. This patch adds a CALCITE_PLANNER_RUNTIME_PROFILE section for the query that expects 10 row groups. Testing: * ran test_compound_predicate_push_down with both planners Change-Id: Ia0ddf3dcce34d93755511d0234339b153de6b72b Assisted-by: Claude Opus 5.5 (Claude Code) Reviewed-on: http://gerrit.cloudera.org:8080/24934 Reviewed-by: Peter Rozsa <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M testdata/workloads/functional-query/queries/QueryTest/iceberg-compound-predicate-push-down.test 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Peter Rozsa: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/24934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia0ddf3dcce34d93755511d0234339b153de6b72b Gerrit-Change-Number: 24934 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]>
