Anubhav Jindal has posted comments on this change. ( http://gerrit.cloudera.org:8080/24929 )
Change subject: IMPALA-15412: Fix Formatting of error_description in WWW-Authenticate Header ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/24929/2/be/src/util/oauth-servers-manager.cc File be/src/util/oauth-servers-manager.cc: http://gerrit.cloudera.org:8080/#/c/24929/2/be/src/util/oauth-servers-manager.cc@33 PS2, Line 33: while (!error_message.empty() && error_message.back() == '\n') { Nit: can we also trim '\r' here (not just '\n')? If a message ends with CRLF, we'd keep a trailing '\r' in the header value http://gerrit.cloudera.org:8080/#/c/24929/2/be/src/util/oauth-servers-manager.cc@37 PS2, Line 37: "error_description=\"$0\"", error_message); Could we add a small regression unit test in oauth-servers-manager-test.cc that asserts the exact Bearer header has no trailing whitespace/newline when Status::GetDetail() ends with newline(s)? -- To view, visit http://gerrit.cloudera.org:8080/24929 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbb593c82afca89394560d21c5ad9a5c49ad2a53 Gerrit-Change-Number: 24929 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 25 Sep 2026 14:52:25 +0000 Gerrit-HasComments: Yes
