Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10939 )
Change subject: IMPALA-7259: Improve Impala shell performance ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/10939/6/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/10939/6/tests/shell/test_shell_commandline.py@664 PS6, Line 664: from time import time It's preferred style to keep imports at the top of modules. You can add time to L31. http://gerrit.cloudera.org:8080/#/c/10939/6/tests/shell/test_shell_commandline.py@672 PS6, Line 672: if actual_time_s > time_limit_s: : assert False, "It took {0} seconds to execute the query. " \ : "Time limit is {1} seconds.".format(actual_time_s, time_limit_s) assert actual_time_s <= time_limit_s, ( "It took {0} seconds to execute the query. Time limit is {1} seconds.".format( actual_time_s, time_limit_s)) -- To view, visit http://gerrit.cloudera.org:8080/10939 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idac9f3caed7c44846a8c922dbe5ca3bf3b095b81 Gerrit-Change-Number: 10939 Gerrit-PatchSet: 6 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 13 Jul 2018 15:58:52 +0000 Gerrit-HasComments: Yes
