Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24880 )
Change subject: IMPALA-15360: Fix /catalog estimated memory column fails to render ...................................................................... IMPALA-15360: Fix /catalog estimated memory column fails to render getReadableSize() in www/scripts/common_util.js actually receives a string type value. When larger than 1e3, it's divided by 1e3 then becomes a number. However, if the original value is smaller than 1e3, it keeps using the string type which doesn't have the toFixed() function. This fails the column rendering in DataTables. This patch fixes the issue by explicitly cast the value to a number. Also adds unit tests for the function. Testing - Ran tests/webui/run-js-tests.sh Assisted-by: Opus 4.8 (Claude Code) Change-Id: Id8e339c6fe6698c170cc1a41ba731c4f35d132ce Reviewed-on: http://gerrit.cloudera.org:8080/24880 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- A tests/webui/js_tests/common/common_util.test.js M www/scripts/common_util.js 2 files changed, 47 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/24880 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id8e339c6fe6698c170cc1a41ba731c4f35d132ce Gerrit-Change-Number: 24880 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
