Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24968 )

Change subject: IMPALA-15447: Iceberg scan telemetry (Stream A + B)
......................................................................


Patch Set 2:

(2 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24968/2/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java
File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java:

http://gerrit.cloudera.org:8080/#/c/24968/2/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@1420
PS2, Line 1420:         if (r.isFailed() || r.getIcebergExpression() == null) 
continue; // keep FULLY+PARTIALLY
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/24968/2/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@1424
PS2, Line 1424:         // Skip anything that won't convert; affects derived 
predicates only, not counters.
line too long (91 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/24968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a290d79ec467a663af32efcce4bcdfebd7d9287
Gerrit-Change-Number: 24968
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Mon, 28 Sep 2026 20:25:45 +0000
Gerrit-HasComments: Yes

Reply via email to