Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23848 )

Change subject: IMPALA-14942: [tools] Impala devcontainer
......................................................................


Patch Set 54: Code-Review+1

(1 comment)

LGTM. I can bump to +2 if no more comments from other reviewers.

http://gerrit.cloudera.org:8080/#/c/23848/52/.devcontainer-build/build-devcontainer.sh
File .devcontainer-build/build-devcontainer.sh:

http://gerrit.cloudera.org:8080/#/c/23848/52/.devcontainer-build/build-devcontainer.sh@99
PS52, Line 99: GIT_REMOTE_NAME="$(git config --get 
"branch.${GIT_BRANCH}.remote")"
> The GIT_HASH, GIT_BRANCH, and GIT_REPO are added as labels to the container
Ack



--
To view, visit http://gerrit.cloudera.org:8080/23848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aa834494003619fcdfbd98f3bfc7c74d3e1554c
Gerrit-Change-Number: 23848
Gerrit-PatchSet: 54
Gerrit-Owner: Jason Fehr <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Gowthami Bisati <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Tue, 29 Sep 2026 01:27:59 +0000
Gerrit-HasComments: Yes

Reply via email to