Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24971 )
Change subject: IMPALA-15449: Reject unschedulable request pools earlier ...................................................................... Patch Set 1: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24971/1/be/src/scheduling/admission-controller-test.cc File be/src/scheduling/admission-controller-test.cc: http://gerrit.cloudera.org:8080/#/c/24971/1/be/src/scheduling/admission-controller-test.cc@2406 PS1, Line 2406: ExecutorGroupNameMatchesPoolForTest("root.default-group-000", "root.default.pool1")); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24971/1/be/src/scheduling/admission-controller.h File be/src/scheduling/admission-controller.h: http://gerrit.cloudera.org:8080/#/c/24971/1/be/src/scheduling/admission-controller.h@340 PS1, Line 340: /// group on this cluster, admission can reject it immediately instead of waiting for queue line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d89201c8a11606659c9ad5b3f904aa66f2beece Gerrit-Change-Number: 24971 Gerrit-PatchSet: 1 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 29 Sep 2026 08:26:29 +0000 Gerrit-HasComments: Yes
