Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24948 )
Change subject: IMPALA-15422: Fix fall-through in system table DECIMAL writer ...................................................................... IMPALA-15422: Fix fall-through in system table DECIMAL writer The switch in WriteDecimalSlot() (system-table-scanner.cc) had no break statements, so after writing the value with the correct width it also wrote it as a Decimal16Value to the same address. All DECIMAL columns of sys.impala_query_live are DECIMAL(18,3), i.e. 8 bytes wide, so every write also overwrote the next 8 bytes of the tuple. Depending on the selected columns, this zeroed other slots or null indicators. E.g. 'select backends_count, total_time_ms from sys.impala_query_live' returned 0 for backends_count. This patch adds the missing break statements. Testing: - Added a custom cluster test that selects backends_count together with each DECIMAL column of sys.impala_query_live. It failed without the fix. Change-Id: I395a217c443f52d3588e0d25bdb1859fb245d04c Assisted-by: Claude Opus 5.5 (1M context) <[email protected]> Reviewed-on: http://gerrit.cloudera.org:8080/24948 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exec/system-table-scanner.cc M tests/custom_cluster/test_query_live.py 2 files changed, 29 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/24948 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I395a217c443f52d3588e0d25bdb1859fb245d04c Gerrit-Change-Number: 24948 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]>
