Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/23745 )
Change subject: IMPALA-14477: [WIP] Speed up test execution (Part 2) ...................................................................... Patch Set 6: Code-Review+1 (5 comments) I think this is pretty close; I added only a few nits. http://gerrit.cloudera.org:8080/#/c/23745/6/docker/entrypoint.sh File docker/entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/23745/6/docker/entrypoint.sh@93 PS6, Line 93: cpu_workload_build 8 > What is the purpose of waiting busily here and in L395? This is an internal mock for testing the Docker-based framework itself. Generates a short burst of high CPU load, simulating a build or test phase without requiring the Impala build/test framework. The sythesized CPU loads helps testing the monitoring/charting parts as well. (this is why it depends on the TEST_TEST_WITH_DOCKER env var; this suggest testing the test driver itself). http://gerrit.cloudera.org:8080/#/c/23745/6/docker/entrypoint.sh@422 PS6, Line 422: make Now that the build uses Ninja, this should be ${IMPALA_MAKE_CMD}, like in https://gerrit.cloudera.org/24644/ http://gerrit.cloudera.org:8080/#/c/23745/6/docker/test-with-docker.py File docker/test-with-docker.py: http://gerrit.cloudera.org:8080/#/c/23745/6/docker/test-with-docker.py@246 PS6, Line 246: evnvars nit: typo http://gerrit.cloudera.org:8080/#/c/23745/6/docker/test-with-docker.py@302 PS6, Line 302: about 60GB of memory, like Amazon's c4.8xlarge (36 CPUs, 60GB) : or c5.9xlarge (36 CPUs, 72GB) or m4.4xlarge (16 CPUs, 64 GB) nit: I'd suggest updating the instance type list to modern ones, e.g. m6i.8xlarge (32 vCPU / 128 GB RAM), m6i.4xlarge (16 vCPU / 64 GB RAM). http://gerrit.cloudera.org:8080/#/c/23745/6/docker/test-with-docker.py@781 PS6, Line 781: jenkins The name "jenkins" is a bit too generic, as -- maybe unfortunately -- most of Cloudera's automation is still run through various Jenkins instances. I'd suggest picking a more specific name, maybe "impala-testcontainer" or something similar. Not a strong request though, this can be updated later as well if you can't find a good candidate. -- To view, visit http://gerrit.cloudera.org:8080/23745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a126d135ad0425c60ce7c7cd6857b455e655fd9 Gerrit-Change-Number: 23745 Gerrit-PatchSet: 6 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Tue, 29 Sep 2026 19:51:12 +0000 Gerrit-HasComments: Yes
