Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24338 )
Change subject: IMPALA-14882: part2: Convert impala tuple batch to arrow record batch ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/24338/8/be/src/exec/arrow-converter-test.cc File be/src/exec/arrow-converter-test.cc: http://gerrit.cloudera.org:8080/#/c/24338/8/be/src/exec/arrow-converter-test.cc@405 PS8, Line 405: TEST_F(ArrowConverterTest, ImpalaToArrowInt8Test) { We should have tests for all types we claim to support: boolean, decimal at 4/8/16 bytes, char, and binary. -- To view, visit http://gerrit.cloudera.org:8080/24338 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37be9989ad6d7016ae1223bc131cb3f6a1af1bb2 Gerrit-Change-Number: 24338 Gerrit-PatchSet: 8 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Wed, 30 Sep 2026 21:30:59 +0000 Gerrit-HasComments: Yes
