Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24940 )
Change subject: IMPALA-11917: Upgrade to GCC 15 and LLVM 22 ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/24940/8/be/src/udf/udf.h File be/src/udf/udf.h: http://gerrit.cloudera.org:8080/#/c/24940/8/be/src/udf/udf.h@735 PS8, Line 735: // __int128_t has 16-byte alignment, but DecimalVals routinely live in 8-byte aligned : // memory (tuple slots, UDA buffers), where aligned SSE accesses (movaps) would fault. : // Lowering val16's alignment to 8 avoids that while keeping the layout (size 32, val16 : // at offset 16) that UDFs compiled against earlier headers expect. : typedef __int128_t int128_align8_t __attribute__((aligned(8))); : > I also vote for 2. Minor correction: is_null is the first byte of DecimalVal. -- To view, visit http://gerrit.cloudera.org:8080/24940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7dda730fa98ebe3825969265627a560b0c3095f9 Gerrit-Change-Number: 24940 Gerrit-PatchSet: 11 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 30 Sep 2026 21:55:09 +0000 Gerrit-HasComments: Yes
