Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24987 )
Change subject: IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests ...................................................................... IMPALA-15137: Fix some flaky TestAdmissionControllerWithACService tests _execute_and_collect_profiles() started the queries in quick succession, expecting them to reach the admission queue in the same order - the fetching of results happens in the original order and was not prepared for out of order admission (the next query can't be admitted before the results of the previous are fetched as result spooling is disabled for these queries). As ExecuteStatement RPC waits only for planning to finish and admission is done on a different thread, a query requested later can actually reach the admission queue earlier. This is more likely in tests with admissiond where the gap between planning and admission is longer, leading to frequent test failures in the ACService case. The fix is to serialize admission by waiting for a query to reach the admission queue (admitted, queued or rejected) before starting the next one. This adds some delay to the function (worst case around 100ms per query start when admissiond is used), but this seems small enough to not alter the semantics of the calling tests. Assisted-by: Claude Opus 5 (Claude Code) Change-Id: I6e0bc611adee662f1e9ce2722ac843dc11dcb3ad Reviewed-on: http://gerrit.cloudera.org:8080/24987 Reviewed-by: Csaba Ringhofer <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M tests/custom_cluster/test_admission_controller.py 1 file changed, 15 insertions(+), 7 deletions(-) Approvals: Csaba Ringhofer: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/24987 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6e0bc611adee662f1e9ce2722ac843dc11dcb3ad Gerrit-Change-Number: 24987 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
