Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/24991 )
Change subject: IMPALA-15461: Look up Iceberg partition specs by id ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Thanks for the fix! http://gerrit.cloudera.org:8080/#/c/24991/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24991/1//COMMIT_MSG@10 PS1, Line 10: Since Iceberg 1.8.0, : ExpireSnapshots.cleanExpiredMetadata(true) removes unused specs and : can leave e.g. only spec 1. nit: This exception could be misleading based on the new logic: https://github.com/apache/impala/blob/2f022a5ca0fc99670bcf197a1f89016cdf78d114/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java#L608 http://gerrit.cloudera.org:8080/#/c/24991/1/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/24991/1/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@137 PS1, Line 137: Preconditions.checkNotNull(feIcebergTable.getPartitionSpecs()); This null check is redundant here, but getDefaultPartitionSpec().hasPartitionFields() could return null, so the check should be moved there. -- To view, visit http://gerrit.cloudera.org:8080/24991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a0aa3364048a3e7957593ca8f98592b43f2fcd8 Gerrit-Change-Number: 24991 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Comment-Date: Fri, 02 Oct 2026 11:17:38 +0000 Gerrit-HasComments: Yes
