Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/25008 )

Change subject: IMPALA-15413: Truncate Parquet page index min/max on UTF-8 
boundaries
......................................................................


Patch Set 1:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/25008/1/be/src/util/string-util.cc
File be/src/util/string-util.cc:

http://gerrit.cloudera.org:8080/#/c/25008/1/be/src/util/string-util.cc@47
PS1, Line 47: /// 
https://github.com/apache/parquet-java/blob/master/parquet-column/src/main/java/org/apache/parquet/internal/column/columnindex/BinaryTruncator.java#L156
line too long (156 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/25008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib50b12a62cfad863825b1994b95a339ef6e5b788
Gerrit-Change-Number: 25008
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Vanko <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Fri, 02 Oct 2026 14:03:36 +0000
Gerrit-HasComments: Yes

Reply via email to