Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24882 )
Change subject: IMPALA-15141 (part 1): Keep codegen enabled for queries on VARIANT ...................................................................... Patch Set 3: (1 comment) Thanks for the review! http://gerrit.cloudera.org:8080/#/c/24882/1/be/src/exec/avro/hdfs-avro-scanner.cc File be/src/exec/avro/hdfs-avro-scanner.cc: http://gerrit.cloudera.org:8080/#/c/24882/1/be/src/exec/avro/hdfs-avro-scanner.cc@807 PS1, Line 807: llvm::StructType* tuple_type = tuple_desc->GetLlvmStruct(codegen); > As far as I know we should never reach this, there's no way to have a VARIA Iceberg V3 spec defines VARIANT for Avro and ORC data files, Spark and Trino write them. Added an FE check next to the UUID check. While looking into this it turned out that Avro codegen can't handle record fields at all (CodegenReadRecord), which breaks even queries that don't reference the VARIANT column. I'll fix that separately (IMPALA-4061 already reported this, as it can happen with STRUCTs as well). -- To view, visit http://gerrit.cloudera.org:8080/24882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e3c59cc41bab7421e0dd450e08944ffc3889241 Gerrit-Change-Number: 24882 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 02 Oct 2026 15:41:29 +0000 Gerrit-HasComments: Yes
