Peter Rozsa has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24840 )

Change subject: IMPALA-15147: Handle token expiration and credential lifetime 
extension for vended credentials
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24840/5/be/src/runtime/query-credentials.cc
File be/src/runtime/query-credentials.cc:

http://gerrit.cloudera.org:8080/#/c/24840/5/be/src/runtime/query-credentials.cc@124
PS5, Line 124:     // it does not skip to another (shorter) prefix or to the 
process-global credentials.
> This sounds like a thinking time bomb to me. If I understood correctly, we
Done


http://gerrit.cloudera.org:8080/#/c/24840/5/fe/src/main/java/org/apache/impala/catalog/local/IcebergMetaProvider.java
File fe/src/main/java/org/apache/impala/catalog/local/IcebergMetaProvider.java:

http://gerrit.cloudera.org:8080/#/c/24840/5/fe/src/main/java/org/apache/impala/catalog/local/IcebergMetaProvider.java@231
PS5, Line 231:    * long-running queries.
> I think we do a full load table here, which sounds like an overkill to fetc
IMPALA-15480 added



--
To view, visit http://gerrit.cloudera.org:8080/24840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fafc33bd78c2cdb19724a7f89536fdd7ad3c6d6
Gerrit-Change-Number: 24840
Gerrit-PatchSet: 6
Gerrit-Owner: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Nandor Kollar <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Comment-Date: Mon, 05 Oct 2026 07:29:07 +0000
Gerrit-HasComments: Yes

Reply via email to