Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/25004 )
Change subject: IMPALA-15467: Calcite planner: Fix DECIMAL return type inference for IF ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/25004/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/CommonOperatorFunctions.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/CommonOperatorFunctions.java: http://gerrit.cloudera.org:8080/#/c/25004/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/CommonOperatorFunctions.java@62 PS2, Line 62: // IF's first operand is the condition, not a possible return value. Keep it Just to be clear because I think this is what you are saying in the comment: The "getSupertypeFunction(name, operandTypes)" requires the first operandType to get the "if" function resolved, but we can then throw it away for the decimal return type for the "if" call? Because it would be slightly cleaner if this code were in getOperandTypes, but it sounds like that is not possible. -- To view, visit http://gerrit.cloudera.org:8080/25004 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3101917e02cae76c48c9d9aaf0d2913de00daffb Gerrit-Change-Number: 25004 Gerrit-PatchSet: 2 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 05 Oct 2026 19:30:50 +0000 Gerrit-HasComments: Yes
