Hello Steve Carlin, Michael Smith,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/25024
to review the following change.
Change subject: IMPALA-15486: Calcite planner: Fix DECIMAL return types for
TRUNC and ROUND
......................................................................
IMPALA-15486: Calcite planner: Fix DECIMAL return types for TRUNC and ROUND
Clamp DECIMAL scale to the input scale and zero, and derive precision
from the remaining digits. Add a carry digit only when ROUND/DROUND
reduce scale; use minimum precision 1 for fractional-only truncation.
Leave non-decimal inference unchanged.
Tests: 20 focused methods standalone, 27 with temporal TRUNC and 24260 PS6.
65 HS2 A/B/A2 cases (195 strict executions, codegen disabled) passed.
10 Calcite fractional-only cases and 10 dynamic codegen cases passed.
All 30 codegen executions matched values and full schemas.
Native 2f022a5; full upstream precommit remains unverified.
Change-Id: I8f6e6e2eaa7fe6eeab88b4143ed6b73e65220333
Assisted-by: GPT-6 (Codex)
---
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaAdjustScaleFunction.java
A
java/calcite-planner/src/test/java/org/apache/impala/calcite/service/CalciteDecimalScaleTest.java
2 files changed, 158 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/25024/1
--
To view, visit http://gerrit.cloudera.org:8080/25024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f6e6e2eaa7fe6eeab88b4143ed6b73e65220333
Gerrit-Change-Number: 25024
Gerrit-PatchSet: 1
Gerrit-Owner: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
