Hello Steve Carlin, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/25018
to look at the new patch set (#3).
Change subject: IMPALA-15481: Calcite planner: Add NVL2 support
......................................................................
IMPALA-15481: Calcite planner: Add NVL2 support
Rewrite unqualified NVL2 calls to IF with an IS NOT NULL selector,
reusing IF validation and coercion.
Add shared query tests for nullness, scalar and decimal return types,
nested calls and row-dependent expressions. Use the test framework's
default planner and fallback settings.
Testing: 64 focused HS2 query executions passed on Original and
Calcite, with fallback disabled, expression rewrites and codegen
on/off. Profiles confirmed codegen on row-dependent cases.
Tested with Java class overlays and existing native binaries,
not a full rebuild. Production code and query cases are unchanged
from the validated PS2; PS3 removes test runner option overrides.
Change-Id: Id2be3b6baacc2e067ffedd70005511e20e4216bd
---
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java
A
java/calcite-planner/src/test/java/org/apache/impala/calcite/service/CalciteNvl2Test.java
A testdata/workloads/functional-query/queries/QueryTest/nvl2.test
M tests/query_test/test_exprs.py
4 files changed, 245 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/25018/3
--
To view, visit http://gerrit.cloudera.org:8080/25018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id2be3b6baacc2e067ffedd70005511e20e4216bd
Gerrit-Change-Number: 25018
Gerrit-PatchSet: 3
Gerrit-Owner: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
