Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24997 )
Change subject: IMPALA-11917: Codegen branch-free reads of nullable scalar slots ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/24997/7/be/src/exprs/slot-ref.cc File be/src/exprs/slot-ref.cc: http://gerrit.cloudera.org:8080/#/c/24997/7/be/src/exprs/slot-ref.cc@239 PS7, Line 239: return !(type_.IsStructType() || type_.IsVariantType() || type_.IsStringType() I understand struct/collection, but what is the reason for excluding the other types? Some type property could make this simpler like static CodegenAnyVal::IsSimplyType(ColumnType). This would allow having default false in new types. http://gerrit.cloudera.org:8080/#/c/24997/7/be/src/exprs/slot-ref.cc@278 PS7, Line 278: CodegenAnyVal result = CodegenAnyVal::GetNonNullVal(codegen, builder, type_, "result"); : result.SetVal(val_or_zero); : result.SetIsNull(is_null); Create a CodegenAnyVal functions for this, e.g. getNullableVal()? -- To view, visit http://gerrit.cloudera.org:8080/24997 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6edaf90100cc3360a7c93d3218eb6956fcec24f0 Gerrit-Change-Number: 24997 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 06 Oct 2026 07:12:30 +0000 Gerrit-HasComments: Yes
