Hello Steve Carlin, Michael Smith,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/25026
to review the following change.
Change subject: IMPALA-15488: Fix integer TRUNC and ROUND calls in Calcite
planner
......................................................................
IMPALA-15488: Fix integer TRUNC and ROUND calls in Calcite planner
Use DOUBLE for one-argument integer calls. For explicit scale, cast the integer
operand to its minimum-resolution DECIMAL and clamp the result scale. Preserve
existing FLOAT/DOUBLE and DECIMAL behavior.
Validation: 24 focused FE tests and 80 Original/Calcite HS2 checks with codegen
off/on (DECIMAL V2).
Change-Id: I4d66850c7de4c04bacbac9f1470e313abdc3ea3c
Assisted-by: GPT-6 (Codex)
---
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaAdjustScaleFunction.java
A
java/calcite-planner/src/test/java/org/apache/impala/calcite/service/CalciteIntegerScaleTest.java
3 files changed, 111 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/25026/1
--
To view, visit http://gerrit.cloudera.org:8080/25026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d66850c7de4c04bacbac9f1470e313abdc3ea3c
Gerrit-Change-Number: 25026
Gerrit-PatchSet: 1
Gerrit-Owner: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
