Hello Steve Carlin, Michael Smith,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/25027
to review the following change.
Change subject: IMPALA-15490: Calcite planner: Normalize arithmetic HBO keys
......................................................................
IMPALA-15490: Calcite planner: Normalize arithmetic HBO keys
Use typed builtin arithmetic forms in HBO keys so Original and Calcite
can reuse history for equivalent predicates. Preserve argument/result
types, explicit casts, operand order and UDF identity. Arithmetic history
keys from the previous format must be collected again.
Add physical-key parity and safety regressions, and update arithmetic-key
expectations.
Change-Id: Ieeab4a08f2f57d1baec7868200195c982544c465
Assisted-by: GPT-6 (Codex)
---
M fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java
A
fe/src/test/java/org/apache/impala/planner/ExprCanonicalizerArithmeticTest.java
M fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java
A
java/calcite-planner/src/test/java/org/apache/impala/calcite/service/CalciteArithmeticHboTest.java
4 files changed, 309 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/25027/1
--
To view, visit http://gerrit.cloudera.org:8080/25027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieeab4a08f2f57d1baec7868200195c982544c465
Gerrit-Change-Number: 25027
Gerrit-PatchSet: 1
Gerrit-Owner: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
