Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24994 )
Change subject: IMPALA-13591: Fix NPE when dropping column used in old partition spec ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/24994/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-alter-v2.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-alter-v2.test: http://gerrit.cloudera.org:8080/#/c/24994/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-alter-v2.test@575 PS3, Line 575: as of now(); This doesn't exercise the old partition specs and dropped columns. We can refer to the first snapshot if we create the table in the python test, then pass the snapshot id as an env_var to run_test_case(). E.g. see: https://github.com/apache/impala/blob/d6638f0d9ea2b66f18cbf76e3c25c59026b9851d/tests/query_test/test_iceberg.py#L1707 -- To view, visit http://gerrit.cloudera.org:8080/24994 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5f1439b31d7f460008760909306607018ac094f Gerrit-Change-Number: 24994 Gerrit-PatchSet: 3 Gerrit-Owner: Nandor Kollar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 06 Oct 2026 14:43:23 +0000 Gerrit-HasComments: Yes
