Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10944 )
Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum) ...................................................................... IMPALA-7288: Fix Codegen Crash in FinalizeModule() (Addendum) In addition to previous fix for IMPALA-7288, this patch would prevent impala from crashing in case a code-path generates a malformed handcrafted function which it then tries to finalize. Ideally this would never happen since the code paths for generating handcrafted IRs would never generate a malformed function. Change-Id: Id09c6f59f677ba30145fb2081715f1a7d89fe20b Reviewed-on: http://gerrit.cloudera.org:8080/10944 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/codegen/llvm-codegen.cc M be/src/codegen/llvm-codegen.h 2 files changed, 3 insertions(+), 6 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10944 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id09c6f59f677ba30145fb2081715f1a7d89fe20b Gerrit-Change-Number: 10944 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>