Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/25034 )
Change subject: IMPALA-15320: Enforce write capabilities for Iceberg and Kudu DML ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Looks good, thanks for working on this! http://gerrit.cloudera.org:8080/#/c/25034/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeModifyStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeModifyStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/25034/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeModifyStmtsTest.java@41 PS1, Line 41: "update " + tableName + " set id = 1 where id = 2", nit: could you please use format strings for more than 2 concats? -- To view, visit http://gerrit.cloudera.org:8080/25034 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7aa7c539a00a0adf8c8c39727e25e274bc98c866 Gerrit-Change-Number: 25034 Gerrit-PatchSet: 1 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 06 Oct 2026 21:29:01 +0000 Gerrit-HasComments: Yes
