Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/25048 )

Change subject:   IMPALA-15281: Support DESCRIBE on partition   Allow DESCRIBE 
and DESCRIBE FORMATTED   to be run on a table partition.
......................................................................


Patch Set 1:

(3 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/25048/1/common/thrift/Frontend.thrift
File common/thrift/Frontend.thrift:

http://gerrit.cloudera.org:8080/#/c/25048/1/common/thrift/Frontend.thrift@236
PS1, Line 236:   5: optional list<CatalogObjects.TPartitionKeyValue> 
partition_spec
Renaming field 'session' to 'partition_spec' in TDescribeTableParams might 
break the compatibility between impalad and catalogd/statestore during upgrade


http://gerrit.cloudera.org:8080/#/c/25048/1/fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java
File fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java:

http://gerrit.cloudera.org:8080/#/c/25048/1/fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java@74
PS1, Line 74:   public DescribeTableStmt(List<String> rawPath, 
TDescribeOutputStyle outputStyle, PartitionSpec partitionSpec) {
line too long (113 > 90)


http://gerrit.cloudera.org:8080/#/c/25048/1/fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java@96
PS1, Line 96:
line has trailing whitespace



--
To view, visit http://gerrit.cloudera.org:8080/25048
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcbd2a4874ba8dd5ec7511f45755ad203b8d6559
Gerrit-Change-Number: 25048
Gerrit-PatchSet: 1
Gerrit-Owner: Anshula Jain <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Wed, 07 Oct 2026 18:58:39 +0000
Gerrit-HasComments: Yes

Reply via email to